-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split off the DockerClientFactory from this library #240
Comments
Hi Luis, I think this is a fair idea; let's just think about the best approach. A separate JAR release from the testcontainers project would be fine, but maybe it's more appropriate to contribute it to the docker-java project if they'd like to have it. It is, after all, coupled to that library, and should also be of utility to their other users. What do people think? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
We have this assigned to the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case. |
Most times I play with other Docker/Java libraries than TestContainers I end up in a world of dependency or configuration hell. It seems like one of the biggest reasons for this is this library's
DockerClientFactory
class, which does a really excellent job of inspecting the environment and choosing the best way of running Docker on the local machine with very little user intervention.This is particularly instrumental when trying to convince other users to adopt Docker-based unit testing—if it doesn't "just work" (as it does!), skeptical developers are prone to reject the whole thing.
Therefore, I think that this class and its supporting cast should perhaps be split off into a separate package or merged upstream so that more people and projects can benefit this most commendable work. I know I'd certainly use it!
The text was updated successfully, but these errors were encountered: