Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the ability to tail child container logs. #233

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Adds the ability to tail child container logs. #233

merged 1 commit into from
Nov 8, 2016

Conversation

pcornish
Copy link

@pcornish pcornish commented Oct 21, 2016 •
edited
Loading

Purpose

See #158.

This PR

  • Adds the ability to tail child container logs.
  • Adds the option to enable/disable pulling of images before starting Compose services. This is useful when images have a repository as part of their image identifier, but have not been pushed (such as when they are being built/tested locally).

@outofcoffee
Adds the ability to tail child container logs. Adds the option to ena…
7e5b8dc 
…ble/disable pulling of images before starting Compose services.
rnorth
rnorth approved these changes Nov 8, 2016
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to review this. It looks good to me - thanks for doing it.

@rnorth rnorth merged commit 292d012 into testcontainers:master Nov 8, 2016
This was referenced Nov 19, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcornish @rnorth @outofcoffee