ISSUE-223 ignore failure at parsing df output #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see #223 |
rnorth
reviewed
Sep 21, 2016
|
|
||
| if (availableMB < 2048) { | ||
| if (df.availableMB.orElseThrow(NotAbleToGetDiskSpaceUsageException::new) < 2048) { |
There was a problem hiding this comment.
Will this throw an exception if free space can't be found?
I think that would be too harsh - maybe the nicest behaviour if the df check returns nothing is to just let the process carry on. It would probably be annoying for a user to be blocked completely just because df doesn't work in their environment.
There was a problem hiding this comment.
It's exactly what I did : the exception is caught into checkDiskSpaceAndHandleExceptions and it just logs a warning. Is that ok to you ?
There was a problem hiding this comment.
Ah OK cool - I'd missed the next stage. Thanks.
|
Thanks for this - will merge now. |
|
great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.