Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when host has untagged images. #201

Merged
merged 1 commit into from
Aug 15, 2016
Merged

Fix NPE when host has untagged images. #201

merged 1 commit into from
Aug 15, 2016

Conversation

kunickiaj
Copy link

When the docker host has untagged images the checkDiskSpace() method will throw a NullPointerException due to getRepoTags() returning null.

This simply adds a null check to avoid this situation.

@kunickiaj kunickiaj mentioned this pull request Aug 15, 2016
@rnorth
Copy link
Member

rnorth commented Aug 15, 2016

Thanks - this looks good to me. Looks like Travis isn't merging in a fix on master for broken dependency shading; sorry about that.

I'm testing locally and expect to merge shortly.

@rnorth rnorth merged commit 0c19d3f into testcontainers:master Aug 15, 2016
@CodingFabian
Copy link
Contributor

I was about to report the same issue. So commenting here to make you aware that this is not singular.
Thanks for the fix @kunickiaj

@rnorth
Copy link
Member

rnorth commented Aug 16, 2016

Yes - this is merged into master and I plan to release ASAP
On Tue, 16 Aug 2016 at 08:30 Fabian Lange [email protected] wrote:

I was about to report the same issue. So commenting here to make you aware
that this is not singular.
Thanks for the fix @kunickiaj https://github.com/kunickiaj


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#201 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIETx3tDDWpg466s4RrAzXCsbGw1Ip8ks5qgWcxgaJpZM4JisZf
.

Richard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants