fix: strip stream headers from logs #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #454 +/- ##
==========================================
+ Coverage 68.44% 68.63% +0.18%
==========================================
Files 21 21
Lines 1892 1932 +40
==========================================
+ Hits 1295 1326 +31
- Misses 480 486 +6
- Partials 117 120 +3
Continue to review full report at Codecov.
|
mdelapenya
approved these changes
Jun 28, 2022
Member
|
Good job here @funvit! 👏👏👏 |
LaurentGoderre
added a commit
to LaurentGoderre/testcontainers-go
that referenced
this pull request
Jul 2, 2025
LaurentGoderre
added a commit
to LaurentGoderre/testcontainers-go
that referenced
this pull request
Jul 2, 2025
mdelapenya
added a commit
that referenced
this pull request
Jul 9, 2025
* modify log consumer test to show how stripping logs sometimes fails bug introduced by #454 * fix: implement the docker log stream specification to strip headers from logs * chore: lint * chore: use require --------- Co-authored-by: Manuel de la Peña <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #365
DockerContainerfuncLogsnow strips header for each line.This fix cannot be used with TTY mode.
Why strip header? Due to setting TTY breaks some tests (ex: Test_ShouldRecognizeLogTypes) ...