From 320b05e7ce5ced93f4aa5cb85217d7c3549b7adb Mon Sep 17 00:00:00 2001 From: Timur Sultanaev <25692644+strowk@users.noreply.github.com> Date: Thu, 30 Oct 2025 19:33:09 +0100 Subject: [PATCH 1/3] should print max information by default When tests do not fail, what they printed rarely matters. However, when they do fail, it is important to see maximum information. This change switches default behavior back as was in 0.31, when failures could be quickly triaged without adding -v --- log/logger.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/log/logger.go b/log/logger.go index d20e90a05a..af2117f099 100644 --- a/log/logger.go +++ b/log/logger.go @@ -19,16 +19,17 @@ type Logger interface { Printf(format string, v ...any) } -// defaultLogger is the default Logger instance. -var defaultLogger Logger = &noopLogger{} +// defaultLogger would print available information to stderr +var defaultLogger Logger = log.New(os.Stderr, "", log.LstdFlags) func init() { // Enable default logger in the testing with a verbose flag. if testing.Testing() { - // Parse manually because testing.Verbose() panics unless flag.Parse() has done. + // Disable logging if explicitly disabled via -test.v=false for _, arg := range os.Args { - if strings.EqualFold(arg, "-test.v=true") || strings.EqualFold(arg, "-v") { - defaultLogger = log.New(os.Stderr, "", log.LstdFlags) + if strings.EqualFold(arg, "-test.v=false") { + defaultLogger = &noopLogger{} + break } } } From e73e10e90830c0510a795d672c5a6a4cc31bb168 Mon Sep 17 00:00:00 2001 From: strowk Date: Thu, 30 Oct 2025 22:15:10 +0100 Subject: [PATCH 2/3] correct comment Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- log/logger.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/log/logger.go b/log/logger.go index af2117f099..3895d2987b 100644 --- a/log/logger.go +++ b/log/logger.go @@ -23,7 +23,7 @@ type Logger interface { var defaultLogger Logger = log.New(os.Stderr, "", log.LstdFlags) func init() { - // Enable default logger in the testing with a verbose flag. + // Disable default logger in testing mode if explicitly disabled via -test.v=false. if testing.Testing() { // Disable logging if explicitly disabled via -test.v=false for _, arg := range os.Args { From fba533ff23797b787a68bc8996a418827e419f95 Mon Sep 17 00:00:00 2001 From: Timur Sultanaev <25692644+strowk@users.noreply.github.com> Date: Sat, 8 Nov 2025 21:00:21 +0100 Subject: [PATCH 3/3] feat: expose noop logger --- log/logger.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/log/logger.go b/log/logger.go index 3895d2987b..b86f568ad1 100644 --- a/log/logger.go +++ b/log/logger.go @@ -22,13 +22,17 @@ type Logger interface { // defaultLogger would print available information to stderr var defaultLogger Logger = log.New(os.Stderr, "", log.LstdFlags) +func NewNoopLogger() Logger { + return &noopLogger{} +} + func init() { // Disable default logger in testing mode if explicitly disabled via -test.v=false. if testing.Testing() { // Disable logging if explicitly disabled via -test.v=false for _, arg := range os.Args { if strings.EqualFold(arg, "-test.v=false") { - defaultLogger = &noopLogger{} + defaultLogger = NewNoopLogger() break } }