-
-
Notifications
You must be signed in to change notification settings - Fork 588
chore(neo4j): use Run function #3419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(neo4j): use Run function #3419
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
No user-facing changes; functionality remains the same. WalkthroughRefactors Neo4j module container setup to use an option-based testcontainers.Run API. Builds a moduleOpts slice with environment, ports, and wait strategy, appends user opts, and runs the container. Replaces GenericContainer/ContainerRequest usage and updates error wording. No exported API changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller
participant Neo4jModule as Neo4j Module
participant TC as testcontainers.Run
participant Ctr as Container
Caller->>Neo4jModule: Run(ctx, opts...)
Neo4jModule->>Neo4jModule: Build moduleOpts\n(WithEnv, WithExposedPorts,\nWithWaitStrategy)
Neo4jModule->>Neo4jModule: Append opts...
Neo4jModule->>TC: Run(ctx, moduleOpts...)
alt success
TC-->>Neo4jModule: ctr
Neo4jModule->>Neo4jModule: Wrap into Neo4jContainer
Neo4jModule-->>Caller: Neo4jContainer
else error
TC-->>Neo4jModule: error
Note right of Neo4jModule: return "run neo4j: %w"
Neo4jModule-->>Caller: error
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)modules/neo4j/neo4j.go (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Use the Run function in neo4j module
Why is it important?
Migrate modules to the new API, improving consistency and leveraging the latest testcontainers functionality.
Related issues