Skip to content

fix(nats): use wait for listening port instead of wait for log #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2025
Merged

fix(nats): use wait for listening port instead of wait for log #3256

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ae5904
nats.go update wait for log
own2pwn Aug 11, 2025
bd9744c
check for both port and log
own2pwn Aug 13, 2025
7bfbd47
single check is sufficient
own2pwn Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/nats/nats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type NATSContainer struct {
// Deprecated: use Run instead
// RunContainer creates an instance of the NATS container type
func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomizer) (*NATSContainer, error) {
return Run(ctx, "nats:2.9", opts...)
return Run(ctx, "nats:2.11.7", opts...)
}

// Run creates an instance of the NATS container type
Expand All @@ -33,7 +33,10 @@ func Run(ctx context.Context, img string, opts ...testcontainers.ContainerCustom
Image: img,
ExposedPorts: []string{defaultClientPort, defaultRoutingPort, defaultMonitoringPort},
Cmd: []string{"-DV", "-js"},
WaitingFor: wait.ForLog("Listening for client connections on 0.0.0.0:4222"),
WaitingFor: wait.ForAll(
wait.ForListeningPort(defaultClientPort),
wait.ForLog("Server is ready"),
),
}

genericContainerReq := testcontainers.GenericContainerRequest{
Expand Down
Loading