Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect use of protected openlayers method getAttributions #1962

Open
simonseyock opened this issue Feb 1, 2021 · 2 comments
Open

incorrect use of protected openlayers method getAttributions #1962

simonseyock opened this issue Feb 1, 2021 · 2 comments
Assignees
Labels

Comments

@simonseyock
Copy link
Member

react-geo uses the protected method getAttributions of openlayers. This means this not something that can be relied upon to be stable. In v6.5.0 it returns a function but in the code it is assumed that it is an Attribution object.

copyright: props.wmsLayer.getSource().getAttributions(),

@simonseyock simonseyock changed the title incorrect of protected getAttributions incorrect use of protected openlayers method getAttributions Feb 1, 2021
@dnlkoch
Copy link
Member

dnlkoch commented Mar 3, 2022

According to the ol API docs it is marked as stable. Can we close this one?

@simonseyock
Copy link
Member Author

Well the result of getAttributions() is still handled like a string, which it isn't. I am currently working on enabling noImplicitAny maybe I can include a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants