Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Scrolling with mouse wheel breaks list order #92

Closed
5 tasks done
ghost opened this issue Jan 19, 2024 · 2 comments
Closed
5 tasks done

[Bug]: Scrolling with mouse wheel breaks list order #92

ghost opened this issue Jan 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jan 19, 2024

Bug Description

if you have 12 location saved in the tempad, when you save a new location then re-open the tempad, if you scroll with the mouse wheel to go lower, the list order breaks. it seens to have no type of order since they are no correlation with the locations.
test1
test1

How to Reproduce?

  1. get 12 location on tempad
  2. add new location
  3. re-open tempad tp menu
  4. scroll up or down with mouse wheel

Expected Behavior

keep the order, not scramble completly

Version

1.4.0

Mod Loader Version

1.18.2

Mod Loader

Forge

Logs or additional context

No response

Code of Conduct

  • I have searched the issue tracker and confirmed that the issue has not been reported
  • I have checked the FAQ (if one is present) and my issue is not listed
  • I have verified that I am using the latest version of the mod
  • I have verified that I have installed all the required dependencies for the mod
  • I have verified that I do not have Optifine installed. We will close issues if we detect Optifine is in your pack. We cannot fix Optifine issues. Please do not report issues with Optifine present.
@ghost ghost added the bug Something isn't working label Jan 19, 2024
@CodexAdrian
Copy link
Member

1.18 is no longer supported

@CodexAdrian CodexAdrian closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
@TheGMYeti
Copy link

Using the Tempad mod in the LPS SteamPunk mod pack (mc version 1.19.2, which you committed to 3 weeks ago) and I can confirm that the list still breaks when you scroll. I even know the reason, but I am not able to fix it right now.
me.codexadrian.tempad.client.gui.RunProgramScreen::init() & me.codexadrian.tempad.client.gui.RunProgramScreen::tick() use different code to fill the list. I can't tell if it is the only issue right now, but from what I can see the issue is cause by init() sorting the list while tick() doesn't. An issue I can see coming up is that it moves at most 12 items of allLocations to shownLocationData before sorting.
I might suggest either adding sorting before moving to shownLocationData for best experience, or removing the sort from init for a quick fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants