Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait longer for AWS creds to propagate #571

Merged
merged 3 commits into from
Oct 25, 2019

Conversation

tyrannosaurus-becks
Copy link
Contributor

This PR adds further delay for AWS creds to propagate. Instead of waiting for 3 total tests of the credentials for them to be considered valid, waits for 5 sequential tries + 5 seconds.

Since sts credentials are immediately consistent, doesn't wait to test them.

@ghost ghost added the size/M label Oct 21, 2019
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

vault/data_source_aws_access_credentials.go Outdated Show resolved Hide resolved
vault/data_source_aws_access_credentials.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small simplification but otherwise LGTM.

@tyrannosaurus-becks tyrannosaurus-becks merged commit a9ed851 into master Oct 25, 2019
@tyrannosaurus-becks tyrannosaurus-becks deleted the delay-returning-aws-creds branch October 25, 2019 20:37
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
…ning-aws-creds

Wait longer for AWS creds to propagate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants