Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Authentication Role resources documentation with changes for Vault 1.2 #487

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Update Authentication Role resources documentation with changes for Vault 1.2 #487

merged 2 commits into from
Aug 5, 2019

Conversation

lawliet89
Copy link
Contributor

This is a continuation of #478

  • Update Terraform to 0.12.6
  • Update documentation with new common token fields.
  • Update the relevant code examples to use Terraform 0.12 syntax

@lawliet89 lawliet89 force-pushed the vault-1.2-auth-docs branch 2 times, most recently from 9059836 to 017e08d Compare August 5, 2019 03:14
@lawliet89 lawliet89 changed the title Update Authentication Role resources with changes for Vault 1.2 Update Authentication Role resources documentation with changes for Vault 1.2 Aug 5, 2019
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Aug 5, 2019
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is tremendously appreciated!

⭐

@tyrannosaurus-becks tyrannosaurus-becks merged commit eb5347c into hashicorp:master Aug 5, 2019
@lawliet89 lawliet89 mentioned this pull request Aug 6, 2019
Closed
lawliet89 added a commit to lawliet89/terraform-provider-vault that referenced this pull request Oct 16, 2019
@lawliet89
Add information about Vault 1.2 for token_* fields
304efd3 
hashicorp#487
deprecated some fields that were deprecated in Vault 1.2

Add more context to deprecation messages that the new `token_*` fields
are only for Vault >= 1.2
@lawliet89 lawliet89 mentioned this pull request Oct 16, 2019
Merged
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@tyrannosaurus-becks
Merge pull request hashicorp#487 from lawliet89/vault-1.2-auth-docs
4c8c285 
Update Authentication Role resources documentation with changes for Vault 1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees

@tyrannosaurus-becks tyrannosaurus-becks

Labels
dependencies size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawliet89 @tyrannosaurus-becks