Allow updating data on vault_database_secret_backend_connection
#340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi @marcinwyszynski ! Thanks for adding this PR! Would it be possible to get test coverage and the other items in the Contributing checklist? |
|
Hi @tyrannosaurus-becks, sure, I'll do my best. |
|
@tyrannosaurus-becks please take another look |
|
Hey @marcinwyszynski since you've got this open, would you please mind fixing the |
|
Hey @cvbarros sure I don't mind but please kindly point me to the exact place that needs to be added. I was looking at the repo but wasn't really sure. Thanks! |
|
@cvbarros @tyrannosaurus-becks ping? 🙇🏼♂️ |
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Allow updating `data` on `vault_database_secret_backend_connection`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
datafield is not taken into account when updating, there is no way we can safely rotate credentials - see the context here.