Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh role add missing parameters #303

Merged
merged 1 commit into from
Feb 19, 2019
Merged

ssh role add missing parameters #303

merged 1 commit into from
Feb 19, 2019

Conversation

nand0p
Copy link

@nand0p nand0p commented Feb 13, 2019

  • adds default_extensions option

@ghost ghost added the size/XS label Feb 13, 2019
@ghost ghost added the documentation label Feb 13, 2019
@nand0p nand0p force-pushed the ssh-role-default-extensions branch 7 times, most recently from fdfc9e1 to ee30531 Compare February 13, 2019 17:20
@nand0p
Copy link
Author

nand0p commented Feb 18, 2019

@tyrannosaurus-becks @martinssipenko thoughts on this? should i add the rest of the missing ssh role options here as well?

martinssipenko
martinssipenko approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@martinssipenko martinssipenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you can please do add other missing options.

@nand0p nand0p changed the title ssh role default extensions ssh role add missing parameters Feb 19, 2019
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nand0p fantastic! Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 71493c4 into hashicorp:master Feb 19, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Merge pull request hashicorp#303 from nand0p/ssh-role-default-extensions
8871f9c 
ssh role add missing parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinssipenko martinssipenko martinssipenko approved these changes

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nand0p @martinssipenko @tyrannosaurus-becks