Skip to content

Support Ed25519 public/private key generation#32

Closed
kaidence wants to merge 6 commits into
hashicorp:masterfrom
kaidence:master
Closed

Support Ed25519 public/private key generation#32
kaidence wants to merge 6 commits into
hashicorp:masterfrom
kaidence:master

Conversation

@kaidence

@kaidence kaidence commented Nov 1, 2018

Copy link
Copy Markdown

Hi! I've been looking to generate Ed25519 keys through Terraform. Unfortunately, this was missing from the official TLS provider. I took a stab at adding support for this. The changes are:

  1. Updates the vendored golang.org/x/crypto
  2. Adds support for Ed25519 in resource_private_key.go, relying on golang.org/x/crypto/ed25519

I'd love for someone to take a look and see whether this is something that could be included in the mainline terraform-provider-tls repository.

@ghost ghost added the size/XXL label Nov 1, 2018
@kaidence

kaidence commented Nov 2, 2018

Copy link
Copy Markdown
Author

The CI fails since the upgraded golang.org/x/crypto package relies on Go 1.9 or higher. Would there be interest in upgrading the required Go version for this project too?

@adamdecaf

Copy link
Copy Markdown

@kaidence I created #33 and PR'd the template project too.

@kaidence

kaidence commented Nov 2, 2018

Copy link
Copy Markdown
Author

@adamdecaf Wonderful, thank you so much!

@kaidence

Copy link
Copy Markdown
Author

Closing this while I get permission from my employer, will reopen once I get that

@kaidence kaidence closed this Nov 12, 2018
@detro detro mentioned this pull request Feb 17, 2022
5 tasks
@detro

detro commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

Thank you for your time and contribution, we really appreciate it. As part of a bigger effort to add complete support for ED25519 key algorithm, I’m closing this in favor of issue #150. Please refer to the new issue for what will be included and how work will proceed.

@github-actions

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants