This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
r/opc_compute_image_list_entry: Fix resource imports #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `opc_compute_image_list_entry` imports. Previously, importing an image list entry would panic if the resource ID was not specified with the correct delimiter `|`. This adds protection for the panic in two places, once during the Read, and once during the Import function. Also updates documentation for importing image list entry resources, and adds an acceptance test for importing image list entries. ``` $ make testacc TEST=./opc TESTARGS="-run=TestAccOPCImageListEntry_importBasic" ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./opc -v -run=TestAccOPCImageListEntry_importBasic -timeout 120m === RUN TestAccOPCImageListEntry_importBasic --- PASS: TestAccOPCImageListEntry_importBasic (15.28s) PASS ok github.com/terraform-providers/terraform-provider-opc/opc 15.289s ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
opc_compute_image_list_entryimports. Previously, importingan image list entry would panic if the resource ID was not specified with
the correct delimiter
|. This adds protection for the panic in two places,once during the Read, and once during the Import function.
Also updates documentation for importing image list entry resources,
and adds an acceptance test for importing image list entries.
Fixes: #26