r/monitor_diagnostic_setting: adding validation/ensuring the casing of the resource id's

[tombuildsstuff]

Fixes #9913

[manicminer]

LGTM 👍

[ghost]

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

[kinzleb]

After I upgraded from 2.41.0 to 2.42.0 I'm now getting a difference detected every time I generate a plan -- it looks like differences in character casing of the value for log_analytics_workspace_id is causing it. Is it possible this change introduced that?

[kinzleb]

Interesting... I read through what this change is fixing and it seemed to cause the problem it was intended to fix in my situation. I manually created the Log Analytics Workspace using the portal and am using the data source for azurerm_log_analytics_workspace to get the ID of it, I'm then using that ID for the log_analytics_workspace_id attribute when creating a resource of type azurerm_monitor_diagnostic_setting and am seeing the behavior where it detects a difference every time I 'terraform plan/apply' because of the casing. Same is true for a azurerm_kubernetes_cluster resource where I'm also using that ID for the oms_agent.log_analytics_workspace_id.

[sharebear]

@kinzleb Have you seen #10116? Sounds like that would be the right place to follow for a fix

[kinzleb]

@kinzleb Have you seen #10116? Sounds like that would be the right place to follow for a fix

That's exactly my issue, thanks for pointing that out @sharebear !

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!