Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_group - support volume.empty_dir #9836

Merged
merged 4 commits into from
Dec 29, 2020

Conversation

afdezl
Copy link
Contributor

@afdezl afdezl commented Dec 11, 2020

This PR adds the emptyDir volume type for ACI.
Note that because Azure requires this to be empty, it is passed as a bool and then turned into an empty object.

@ghost ghost added the documentation label Dec 13, 2020
@afdezl
Copy link
Contributor Author

afdezl commented Dec 15, 2020

References: #1860

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @afdezl - overall this looks great but we will need to set the value for empty dir on read to prevent this a failing test:

container.0.volume.0.empty_dir: "false" => "true" (forces new resource)

@katbyte katbyte added this to the v2.42.0 milestone Dec 27, 2020
@afdezl
Copy link
Contributor Author

afdezl commented Dec 29, 2020

Thanks for the PR @afdezl - overall this looks great but we will need to set the value for empty dir on read to prevent this a failing test:

container.0.volume.0.empty_dir: "false" => "true" (forces new resource)

Thanks @katbyte. Just implemented.

@ghost ghost removed the waiting-response label Dec 29, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afdezl - this LGTM now 🚀

@katbyte katbyte changed the title Implements emptyDir volume type for ACI azurerm_container_group - support empty_dir Dec 29, 2020
@katbyte katbyte changed the title azurerm_container_group - support empty_dir azurerm_container_group - support volume.empty_dir Dec 29, 2020
@katbyte katbyte merged commit 3709f4b into hashicorp:master Dec 29, 2020
katbyte added a commit that referenced this pull request Dec 29, 2020
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 29, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants