Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New block dimensions in azurerm_monitor_autoscale_setting\profile\rule\metric_trigger #9795

Merged
merged 4 commits into from
Jan 19, 2021

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Dec 10, 2020

Fix #5969

=== RUN TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions
=== PAUSE TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions
=== CONT TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions
--- PASS: TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions (562.56s)

All other tests have passed.

@yupwei68 yupwei68 changed the title New block dimensions in azurerm_monitor_autoscale_setting \profile \rule \metric_trigger New block dimensions in azurerm_monitor_autoscale_setting\profile\rule\metric_trigger Dec 10, 2020
@yupwei68 yupwei68 changed the title New block dimensions in azurerm_monitor_autoscale_setting\profile\rule\metric_trigger New block dimensions in azurerm_monitor_autoscale_setting\profile\rule\metric_trigger Dec 10, 2020
@yupwei68
Copy link
Contributor Author

I've merged the upstream. Please continue reviewing.
=== RUN TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions
=== PAUSE TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions
=== CONT TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions
--- PASS: TestAccAzureRMMonitorAutoScaleSetting_multipleRulesDimensions (605.39s)

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - This LGTM 👍

@jackofallops jackofallops added this to the v2.44.0 milestone Jan 19, 2021
@jackofallops
Copy link
Member

Tests passing, failures unrelated to change:
image

@jackofallops jackofallops merged commit 9271711 into hashicorp:master Jan 19, 2021
jackofallops added a commit that referenced this pull request Jan 19, 2021
@ghost
Copy link

ghost commented Jan 21, 2021

This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.44.0"
}
# ... other configuration ...

@yupwei68 yupwei68 deleted the wyp-monitor-as branch January 25, 2021 02:21
@ghost
Copy link

ghost commented Feb 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for namespace and dimension parameters in azurerm_monitor_autoscale_setting
2 participants