Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_digital_twins_endpoint_eventhub #9673

Merged
merged 28 commits into from
Dec 4, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Dec 4, 2020

Partial fix: #9211

=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_basic
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_basic
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_basic
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_basic (348.23s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport (363.34s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub (471.41s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter (479.86s)

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68 Thanks you for submitting this PR, it's looking really good so far and is almost there. I left a couple of comments if you don't mind making those changes I think this would be good to go! 🚀

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68, this looks good however I missed something on my first review, can we get the test names updated? I think once that is done we are good to go. 🚀

@yupwei68
Copy link
Contributor Author

yupwei68 commented Dec 4, 2020

@WodansSon Thanks Jeffrey for latest information. Changes have been pushed. Please continue reviewing.

@WodansSon
Copy link
Collaborator

image

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68, thanks for pushing the changes! This LGTM now! 🚀

@WodansSon WodansSon merged commit e4ba763 into hashicorp:master Dec 4, 2020
WodansSon added a commit that referenced this pull request Dec 4, 2020
@ghost
Copy link

ghost commented Jan 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2021
@yupwei68 yupwei68 deleted the wyp-digitaltwins-eventhub branch January 25, 2021 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Digital Twins
3 participants