Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - allow hns when account_tier is Premium #9548

Merged
merged 3 commits into from
Dec 31, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #9528

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - left some comments inline to address before merge

@@ -107,7 +107,7 @@ The following arguments are supported:

* `is_hns_enabled` - (Optional) Is Hierarchical Namespace enabled? This can be used with Azure Data Lake Storage Gen 2 ([see here for more information](https://docs.microsoft.com/en-us/azure/storage/blobs/data-lake-storage-quickstart-create-account/)). Changing this forces a new resource to be created.

-> **NOTE:** When this is set to `true` the `account_tier` argument must be set to `Standard`
-> **NOTE:** When this is set to `true` the `account_tier` argument could be set to `Standard` or `Premium`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-> **NOTE:** When this is set to `true` the `account_tier` argument could be set to `Standard` or `Premium`.
-> **NOTE:** this can only be `true` when `account_tier` is `Standard` or `Premium`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@@ -819,6 +819,25 @@ func TestAccAzureRMStorageAccount_largeFileShare(t *testing.T) {
})
}

func TestAccAzureRMStorageAccount_withPremiumBlockBlobStorageAndEnabledHns(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update this to the new test framework?

Suggested change
func TestAccAzureRMStorageAccount_withPremiumBlockBlobStorageAndEnabledHns(t *testing.T) {
func TestAccStorageAccount_hnsWithPremiumStorage(t *testing.T) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@katbyte katbyte added this to the v2.42.0 milestone Dec 27, 2020
@neil-yechenwei
Copy link
Contributor Author

@katbyte , thanks for your comments. I've updated code. Please have an another look.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - this LGTM 👍

@katbyte katbyte changed the title Support Premium BlockBlobStorage when hns is enabled azurerm_storage_account - allow Premium BlockBlobStorage when hns is enabled Dec 31, 2020
@katbyte katbyte changed the title azurerm_storage_account - allow Premium BlockBlobStorage when hns is enabled azurerm_storage_account - allow hns when account_tier is Premium Dec 31, 2020
@katbyte katbyte merged commit 03858f0 into hashicorp:master Dec 31, 2020
katbyte added a commit that referenced this pull request Dec 31, 2020
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ADLS Gen 2 Premium for azurerm_storage_account
2 participants