Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_media_services_account - support for 'identity', 'tags' and 'storage_authentication' #9457

Merged
merged 7 commits into from
Dec 3, 2020
Merged

Conversation

jcanizalez
Copy link
Contributor

@jcanizalez jcanizalez commented Nov 24, 2020

Including the support for the properties Identity and Storage Authentication in Azure Media Services Account. In order to support new fields was required to update the API version to new version 2020-05-01, but I have already validated that the Acceptance test still works. Additional take advantage of including support for tags. This PR resolves #9404

Checked:

  • Include support for properties identity, tags and storage_authentication.
  • Update Documentation
  • Add new Acceptance Test and verified that the tests pass successfully
  • Check linting

@jcanizalez jcanizalez changed the title Support for new properties (identity, tags and storage_authentication) in azurerm_media_services_account azurerm_media_services_account support for identity, tags and storage_authentication Nov 26, 2020
@jcanizalez jcanizalez changed the title azurerm_media_services_account support for identity, tags and storage_authentication azurerm_media_services_account - support for identity, tags and storage_authentication Nov 26, 2020
@jcanizalez jcanizalez changed the title azurerm_media_services_account - support for identity, tags and storage_authentication azurerm_media_services_account - support for 'identity', 'tags' and 'storage_authentication' Nov 26, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - given this a review and left some comments inline 🙂

@jcanizalez
Copy link
Contributor Author

Thanks @katbyte I already applied your suggestions

@jackofallops
Copy link
Member

Hi @jcanizalez - Hope you don't mind, but I fixed a potential panic for the new property and I switched over to the new IDs while I was there. I'll get the tests run shortly and assuming they pass OK, we'll get this merged later today. Thanks again for the contribution!

@jackofallops
Copy link
Member

Tests passing:
image

@jcanizalez
Copy link
Contributor Author

Thanks @jackofallops

@katbyte katbyte added this to the v2.39.0 milestone Dec 3, 2020
@katbyte katbyte merged commit 7c5e954 into hashicorp:master Dec 3, 2020
katbyte added a commit that referenced this pull request Dec 3, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

This has been released in version 2.39.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.39.0"
}
# ... other configuration ...

@jcanizalez jcanizalez deleted the msa_new_properties branch December 8, 2020 15:58
@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for new properties (identity and storage_authentication) in azurerm_media_services_account
3 participants