Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to API version 2020-06-01 for App Service #9409

Merged
merged 8 commits into from
Nov 24, 2020

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Nov 20, 2020

Address Breaking changes:

  • Enum for internal_load_balancing_mode changed from Web, Publishing to Web,Publishing

@AdamCoulterOz
Copy link
Contributor

Breaking changes:

  • Enum for internal_load_balancing_mode changed from Web, Publishing to Web,Publishing

Could it not be made non-breaking by adding:

internalLoadBalancingMode := d.Get("internal_load_balancing_mode").(string)
internalLoadBalancingMode = strings.ReplaceAll(internalLoadBalancingMode, " ", "")

and adding a warning?

@tombuildsstuff
Copy link
Contributor

+1 we can add a bi-directional mapping here - converting to/from Web, Publishing - since other API's use the same [value1], [value2] convention for MSI

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a few comments this LGTM :

azurerm/internal/services/web/app_service.go Outdated Show resolved Hide resolved
azurerm/internal/services/web/app_service.go Outdated Show resolved Hide resolved
azurerm/internal/services/web/app_service.go Outdated Show resolved Hide resolved
@jackofallops jackofallops marked this pull request as ready for review November 24, 2020 11:49
@jackofallops
Copy link
Member Author

Tests looking good, (failures unrelated to SDK change)
image

@jackofallops jackofallops merged commit 3007149 into master Nov 24, 2020
@jackofallops jackofallops deleted the sdk/app-service-2020-06-01 branch November 24, 2020 13:28
jackofallops added a commit that referenced this pull request Nov 24, 2020
@ghost
Copy link

ghost commented Nov 27, 2020

This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants