Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_storage_share_file #9406

Merged
merged 13 commits into from
Dec 8, 2020
Merged

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Nov 20, 2020

Fixes #5132

@ghost ghost added the documentation label Nov 24, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.38.0, v2.39.0 Nov 26, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments whilst passing through, but I think we should be able to remove the parallelism field, since it appears to be unused

Required: true,
ForceNew: true,
ValidateFunc: validation.StringIsNotEmpty,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably replace these two with file_share_id here and determine the rest tbh

Type: schema.TypeInt,
Optional: true,
Default: 4,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to remove this since it's unused

ForceNew: true,
ValidateFunc: validation.StringIsNotEmpty,
},
"directory_name": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the SDK makes this path - it may be worth doing the same here?

@mbfrahry mbfrahry marked this pull request as ready for review December 1, 2020 22:50
@mbfrahry mbfrahry changed the title [WIP] New Resource: azurerm_storage_share_file New Resource: azurerm_storage_share_file Dec 1, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.39.0, v2.40.0 Dec 3, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments LGTM 👍

"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/clients"
)

func TestAccAzureRMStorageShareFile_basic(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are slowly updating all the tests might be a good idea to switch this over now

Suggested change
func TestAccAzureRMStorageShareFile_basic(t *testing.T) {
func TestAccStorageShareFile_basic(t *testing.T) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as use the test shim

}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%d"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "acctestRG-%d"
name = "acctestRG-storage-%d"

@mbfrahry mbfrahry merged commit 91c13df into master Dec 8, 2020
@mbfrahry mbfrahry deleted the f-storage-share-file branch December 8, 2020 23:14
mbfrahry added a commit that referenced this pull request Dec 8, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jan 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_storage_file
3 participants