support multiple Radius Server for vpn_server_configuration_resource #9308
Conversation
azurerm/internal/services/network/vpn_server_configuration_resource.go
Outdated
Show resolved
Hide resolved
| Sensitive: true, | ||
| }, | ||
|
|
||
| "server": { |
There was a problem hiding this comment.
Instead of adding a sub block here, can we just remove the max items on radius server, add score, and then if score is set, us the new property, and if score is not set & there is only 1 radius server use the old property?
There was a problem hiding this comment.
Agree, that's a better solution. I'll do the change.
There was a problem hiding this comment.
I forget to mention that after removing the constrain of max items on radius server, we need to lift client_root_certificate
and server_root_certificate in the radius server block to the outer scope, since these two settings are shared by all radius servers. If so, it will introduce a break-change. Now we're in the situation either introduce a break change or compromise a little bit as what I did in the current PR. So before proceed, I'd like to know your opinion on it.
There was a problem hiding this comment.
oh dang, didn't notice those! hmm
What we could do is keep radius_server as is and deprecated it then add a new block radius which would have those two properties and have a servers list inside. Then we can make them conflict so the user has to pick one or the other and we just use the one that is configured?
There was a problem hiding this comment.
I've done the change based on your suggestion.
There was a problem hiding this comment.
@katbyte Since the waiting-response label still there, just ping you again in case you didn't notice my above reply. thanks.
| @@ -98,6 +98,25 @@ func TestAccAzureRMVPNServerConfiguration_radius(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccAzureRMVPNServerConfiguration_multipleRadius(t *testing.T) { | |||
There was a problem hiding this comment.
Could we add some more tests?
Going from 1 server with the old block -> 1 server with the new block, updating the new block from 1 -> 2 -> 1 -> none?
There was a problem hiding this comment.
@katbyte tests has been updated.
|
This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.38.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Spec:
https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/Microsoft.Network/stable/2020-05-01/virtualWan.json#L5895
ACC Tests result:
