azurerm_vpn_gateway - support block "bgp_peering_addresses"

[njuCZ]

After confirmed with service team, this field "bgp_peering_addresses" could not be set when creating, otherwise the rest api will report error. It could only be updated.

[katbyte]

Thanks for the PR @njuCZ - however i think the block/properties are poorly named and confusing.

it seems like the block is tied to an "instance" and then these are the addresses for it? we should name the block something that is a bit more explicit, like bgp_ip|instance_peering_addresses and then inside ip|instance_id ?

[njuCZ]

Hi @katbyte thanks for your review. After consulting the service team further, they say IpconfigurationID is fixed to Instance0 and Instance1. Users could not change it.

The portal's experience is: creating VPN Gateway only needs parameters of AS number and gateway scale units. and updating could only update custom bgp ip address, the picture is shown blow

So my sugggestion is to make IpconfigurationID computed, and limit the size of instance_bgp_peering_address block to 2. Do you think it is ok? I have modified this PR, could you have a look again?

[katbyte]

Hey @njuCZ - i've been thinking about this on and off for a week and i dont' this the current schema is very clear or good ux. I've left some comments inline but basically i think creating two named blocks might be the best and most clear solution here? WDYT?

[njuCZ]

@katbyte thanks for your review, I have modifed this PR, please have a look when free

[katbyte]

Thanks @njuCZ - LGTM 👍

[ghost]

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!