azurerm_postgresql_firewall_rule - add validation for start_ip_address and end_ip_address
#8963
Conversation
|
Hi @tombuildsstuff , let me know if this PR looks good. Thanks in advance, Ritesh |
There was a problem hiding this comment.
@ritesh-modi Thank you for this PR! 👍
Overall It LGTM, whilst can we split this PR into two? One for adding the validation for the postgres firewall resource, and the other for supporting the same size kubernetes cluster node pool.
|
Hello @magodo Thanks for letting me know about changes required. I have done the needed changes and please help in closing the PR. |
|
@ritesh-modi |
|
@magodo, no other motivation apart from learning and contributing to open-source. Also, yes the resource expect ipv4 address only.
|
|
@ritesh-modi Thanks 👍 |
magodo
changed the title
azurerm_postgresql_firewall_rule - add validation for start_ip_address and end_ip_address
|
@ritesh-modi One thing I overlooked is that i noticed you are using the validation function from the provider code base. However, we are now prefer using the ones from terraform plugin sdk if available. So in your case, you might want to use |
|
Sure @magodo, I have done this change. thanks for informing ! |
|
|
|
This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.35.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Added postgres firewall start and end IP address validation
Acceptance tests details
riteshmodi@MININT-3FOKASG terraform-provider-azurerm % make acctests SERVICE=postgres TESTARGS='-run=TestAccAzureRMPostgreSQLFirewallRule' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/postgres/tests/ -run=TestAccAzureRMPostgreSQLFirewallRule -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMPostgreSQLFirewallRule_basic
=== PAUSE TestAccAzureRMPostgreSQLFirewallRule_basic
=== RUN TestAccAzureRMPostgreSQLFirewallRule_requiresImport
=== PAUSE TestAccAzureRMPostgreSQLFirewallRule_requiresImport
=== CONT TestAccAzureRMPostgreSQLFirewallRule_basic
=== CONT TestAccAzureRMPostgreSQLFirewallRule_requiresImport
--- PASS: TestAccAzureRMPostgreSQLFirewallRule_basic (264.14s)
--- PASS: TestAccAzureRMPostgreSQLFirewallRule_requiresImport (269.61s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/postgres/tests 269.659s