Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Redis Cache firewall resource start and end IP address validations #8948

Merged
merged 3 commits into from
Oct 20, 2020

Conversation

ritesh-modi
Copy link
Contributor

Added Redis Cache firewall resource start and end IP address validations such that the request fails at plan level rather than apply. The validations will provide feedback for invalid ip addresses during plan itself.

Details of acceptance tests

riteshmodi@MININT-3FOKASG terraform-provider-azurerm % make acctests SERVICE=redis TESTARGS='-run=TestAccAzureRMRedisFirewallRule' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/redis/tests/ -run=TestAccAzureRMRedisFirewallRule -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMRedisFirewallRule_basic
=== PAUSE TestAccAzureRMRedisFirewallRule_basic
=== RUN TestAccAzureRMRedisFirewallRule_multi
=== PAUSE TestAccAzureRMRedisFirewallRule_multi
=== RUN TestAccAzureRMRedisFirewallRule_requiresImport
=== PAUSE TestAccAzureRMRedisFirewallRule_requiresImport
=== RUN TestAccAzureRMRedisFirewallRule_update
=== PAUSE TestAccAzureRMRedisFirewallRule_update
=== CONT TestAccAzureRMRedisFirewallRule_basic
=== CONT TestAccAzureRMRedisFirewallRule_update
=== CONT TestAccAzureRMRedisFirewallRule_requiresImport
=== CONT TestAccAzureRMRedisFirewallRule_multi
--- PASS: TestAccAzureRMRedisFirewallRule_requiresImport (1324.42s)
--- PASS: TestAccAzureRMRedisFirewallRule_update (1395.16s)
--- PASS: TestAccAzureRMRedisFirewallRule_multi (1432.15s)
--- PASS: TestAccAzureRMRedisFirewallRule_basic (1491.06s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis/tests 1491.109s

@ghost ghost added the size/XS label Oct 20, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @ritesh-modi

@tombuildsstuff tombuildsstuff added this to the v2.33.0 milestone Oct 20, 2020
@tombuildsstuff tombuildsstuff merged commit 08b138b into hashicorp:master Oct 20, 2020
tombuildsstuff added a commit that referenced this pull request Oct 20, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants