Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azurerm_function_app] App Settings should be Computed #8682

Merged
merged 1 commit into from
Oct 4, 2020
Merged

[azurerm_function_app] App Settings should be Computed #8682

merged 1 commit into from
Oct 4, 2020

Conversation

nexxai
Copy link
Contributor

@nexxai nexxai commented Sep 29, 2020

Function Apps should have computed App Settings just like App Services do, since they are effectively two different offshoots of the same resource type behind the scenes.

Also required as discussed in this thread

@ghost ghost added the size/XS label Sep 29, 2020
@nexxai nexxai changed the title App Settings on Function Apps should be computed [azurerm_function_app] App Settings on should be Computed Sep 29, 2020
@nexxai nexxai changed the title [azurerm_function_app] App Settings on should be Computed [azurerm_function_app] App Settings should be Computed Sep 29, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nexxai - LGTM 👍

@katbyte katbyte added bug service/functions Function Apps labels Oct 4, 2020
@katbyte katbyte added this to the v2.31.0 milestone Oct 4, 2020
@katbyte katbyte merged commit d3a3de0 into hashicorp:master Oct 4, 2020
katbyte added a commit that referenced this pull request Oct 4, 2020
@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@drdamour
Copy link
Contributor

drdamour commented Oct 8, 2020

@nexxai does this fix #5112 too ?

@nexxai nexxai deleted the update-function-apps-to-use-computed-properties-for-app-settings branch October 8, 2020 20:13
@nexxai
Copy link
Contributor Author

nexxai commented Oct 8, 2020

@drdamour No, you will still need to add the fields you wish Terraform to ignore.

@ghost
Copy link

ghost commented Nov 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants