-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_sentinel_alert_rule_scheduled: support incident configuration #8564
azurerm_sentinel_alert_rule_scheduled: support incident configuration #8564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @magodo - overall this is off to a good start. I've left some comments inline that once addressed this should be good to merge
azurerm/internal/services/sentinel/resource_arm_sentinel_alert_rule_scheduled.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/sentinel/resource_arm_sentinel_alert_rule_scheduled.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/sentinel/resource_arm_sentinel_alert_rule_scheduled.go
Outdated
Show resolved
Hide resolved
@katbyte Thank you for your review! I have updated accordingly, please take another look! |
@magodo - could we fix the merge conflicts? once thats done i think this is good to merge |
@katbyte I've resolved the conflicts, please take another look! 💤 make testacc TEST=./azurerm/internal/services/sentinel TESTARGS='-run TestAccSentinelAlertRuleScheduled_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/sentinel -v -run TestAccSentinelAlertRuleScheduled_ -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccSentinelAlertRuleScheduled_basic
=== PAUSE TestAccSentinelAlertRuleScheduled_basic
=== RUN TestAccSentinelAlertRuleScheduled_complete
=== PAUSE TestAccSentinelAlertRuleScheduled_complete
=== RUN TestAccSentinelAlertRuleScheduled_update
=== PAUSE TestAccSentinelAlertRuleScheduled_update
=== RUN TestAccSentinelAlertRuleScheduled_requiresImport
=== PAUSE TestAccSentinelAlertRuleScheduled_requiresImport
=== RUN TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== PAUSE TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== CONT TestAccSentinelAlertRuleScheduled_basic
=== CONT TestAccSentinelAlertRuleScheduled_requiresImport
=== CONT TestAccSentinelAlertRuleScheduled_update
=== CONT TestAccSentinelAlertRuleScheduled_complete
=== CONT TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
--- PASS: TestAccSentinelAlertRuleScheduled_basic (208.04s)
--- PASS: TestAccSentinelAlertRuleScheduled_complete (210.88s)
--- PASS: TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid (214.42s)
--- PASS: TestAccSentinelAlertRuleScheduled_requiresImport (219.25s)
--- PASS: TestAccSentinelAlertRuleScheduled_update (457.98s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/sentinel 458.025s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.42.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Fixes: #8545
Test Result