API Manager: Support for virtual network mode with additional locations #8290
Conversation
There was a problem hiding this comment.
Hi @jake-scott, thanks for this PR! This is mostly looking great, just a few minor suggestions and a query regarding the docs - seems like you may have edited the wrong docs page? Incidentally, could you also add the new properties to the corresponding data source? If we can fix up the docs, and patch up the data source to match, this looks good to merge :)
azurerm/internal/services/apimanagement/api_management_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/apimanagement/api_management_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/apimanagement/api_management_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/apimanagement/api_management_resource.go
Outdated
Show resolved
Hide resolved
Fixes: #6642 Adds support for virtual_network_configuration blocks within an additional_location block, to support multipl locations in Internal or External vnet mode. Addionally adds private_ip_addresses to the API Management data source and updates the documentation.
|
@jake-scott Thanks for the changes! I'm running acceptance tests now. |
|
Test results (3 unrelated failures):
|
|
This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.29.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Fixes: #6642
Adds support for virtual_network_configuration blocks within an
additional_location block, to support multipl locations in Internal
or External vnet mode.