azurerm_shared_image - Support for purchase_plan
#8124
Conversation
| @@ -344,3 +374,53 @@ func flattenGalleryImageIdentifier(input *compute.GalleryImageIdentifier) []inte | |||
| }, | |||
| } | |||
| } | |||
|
|
|||
| func expandGalleryImagePurchasePlan(input []interface{}) *compute.ImagePurchasePlan { | |||
| if len(input) == 0 { | |||
There was a problem hiding this comment.
We'll want to check that input[0] doesn't equal nil as well so we don't panic
| if len(input) == 0 { | |
| if len(input) == 0 && input[0] != nil { |
There was a problem hiding this comment.
I suppose this should be
| if len(input) == 0 { | |
| if len(input) == 0 || input[0] == nil { |
if we are doing a nil check here?
There was a problem hiding this comment.
And I suppose since the name attribute in this block is required, the situation input[0] == nil will never happen, right?
There was a problem hiding this comment.
But I still added this check for safety
There was a problem hiding this comment.
Oh yes! Thanks for catching that || instead of &&. We should check even if should never happen as a just in case.
|
Hi @mbfrahry I have made some changes, please have a look, thanks! |
mbfrahry
changed the title
azurerm_shared_image - Support purchase_planazurerm_shared_image - Support purchase_plan
mbfrahry
changed the title
azurerm_shared_image - Support purchase_planazurerm_shared_image - Support for purchase_plan
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #7962