Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_iothub - support for the endpoint.resource_group property #8032

Merged
merged 7 commits into from
Oct 26, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #3295

--- PASS: TestAccAzureRMIotHub_standard (310.27s)
--- PASS: TestAccAzureRMIotHub_ipFilterRules (321.22s)
--- PASS: TestAccAzureRMIotHub_fallbackRoute (321.66s)
--- PASS: TestAccAzureRMIotHub_requiresImport (343.44s)
--- PASS: TestAccAzureRMIotHub_fileUpload (375.62s)
--- PASS: TestAccAzureRMIotHub_basic (409.36s)
--- PASS: TestAccAzureRMIotHub_customRoutes (463.73s)
--- PASS: TestAccAzureRMIotHub_withDifferentEndpointResourceGroup (582.51s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei - overall this looks good but i've left some comments inline that need to be addressed before merge

azurerm/internal/services/iothub/iothub_resource.go Outdated Show resolved Hide resolved
website/docs/r/iothub.html.markdown Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks.

@ghost ghost removed the waiting-response label Oct 13, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei, aside from one comment that needs to be addressed this LGTM 👍

azurerm/helpers/azure/resource_group.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v2.34.0 milestone Oct 22, 2020
@ghost ghost added size/M and removed size/L labels Oct 22, 2020
@neil-yechenwei
Copy link
Contributor Author

@katbyte , thanks for your comment. I've updated code by your comment. Please have a look. Thanks.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei! this LGTM now

@katbyte katbyte changed the title Allow to specify endpoint resource group for azurerm_iothub azurerm_iothub - support for the endpoint.resource_group property Oct 26, 2020
@katbyte katbyte merged commit 4f82167 into hashicorp:master Oct 26, 2020
katbyte added a commit that referenced this pull request Oct 26, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IoT hub endpoint created assuming same resource group
3 participants