Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the compute API to 2017-12-01 / upgrading to Azure SDK v12.4 #797

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Update the compute API to 2017-12-01 / upgrading to Azure SDK v12.4 #797

merged 2 commits into from
Feb 7, 2018

Conversation

justenwalker
Copy link
Contributor

@justenwalker justenwalker commented Feb 5, 2018 •
edited
Loading

Fixes #799

  • Update the azure-sdk-for-go to v12.4.0-beta since this is the version
    that introduced 2017-12-01/compute
  • Change all 2017-03-30/compute import statements to 2017-12-01/compute

@justenwalker
Update the compute API to 2017-12-01
dbd2039 
- Update the azure-sdk-for-go to v12.4.0-beta since this is the version
  that introduced 2017-12-01/compute
- Change all 2017-03-30/compute import statements to 2017-12-01/compute
@justenwalker
Remove 2017-03-30/compute from vendor.json
1c4d661
@justenwalker justenwalker mentioned this pull request Feb 5, 2018
Closed
@tombuildsstuff tombuildsstuff added this to the 1.1.2 milestone Feb 5, 2018
@tombuildsstuff
Copy link
Contributor

hey @justenwalker

Thanks for this PR - just to let you know that we'll be looking to get this in as part of v1.1.2, in which we'll upgrade the entire Azure SDK to v12.4 - which is targeted for next week.

Thanks!

@tombuildsstuff tombuildsstuff changed the title Update the compute API to 2017-12-01 Update the compute API to 2017-12-01 / upgrading to Azure SDK v12.4 Feb 6, 2018
tombuildsstuff
tombuildsstuff approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @justenwalker

Thanks for this PR - I've taken a look through and this LGTM 👍

I've run a few VM tests against Azure Public and Azure Germany and this seems to work as expected, as such I'm going to merge this as-is and this will go out as part of v1.1.2.

Thanks!

@tombuildsstuff tombuildsstuff merged commit d3583ea into hashicorp:master Feb 7, 2018
tombuildsstuff added a commit that referenced this pull request Feb 7, 2018
@tombuildsstuff
Updating to include #797
5ee0840
@justenwalker
Copy link
Contributor Author

@tombuildsstuff Thanks!

@justenwalker justenwalker deleted the update-compute-api branch February 7, 2018 01:02
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@metacpp metacpp metacpp approved these changes

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
v1.1.2
Development

Successfully merging this pull request may close these issues.

VM Scale Set deployments on API 2017-03-30 fail due to ambiguous ssh keys representation
3 participants
@justenwalker @tombuildsstuff @metacpp