Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property allow_blob_public_access to azurerm_storage_account #7739

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Add property allow_blob_public_access to azurerm_storage_account #7739

merged 2 commits into from
Jul 14, 2020

Conversation

sdebruyn
Copy link
Contributor

@sdebruyn sdebruyn commented Jul 14, 2020

Implementation for #7738

Fixes #7738

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @sdebruyn

@favoretti
Copy link
Collaborator

Fixes #7673 too.

@favoretti
Copy link
Collaborator

Also there was a dupe implementation proposed in #7700 so that one can be closed then :) But great that it is coming! Thanks @sdebruyn

@sdebruyn
Copy link
Contributor Author

My bad, I should have seen that, sorry :/

@tombuildsstuff
Copy link
Contributor

@favoretti sorry - I'd missed that this was a duplicate before reviewing

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-07-14 at 12 16 56

@tombuildsstuff tombuildsstuff merged commit 6a8e91a into hashicorp:master Jul 14, 2020
tombuildsstuff added a commit that referenced this pull request Jul 14, 2020
@ghost
Copy link

ghost commented Jul 16, 2020

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

@drhbigdave
Copy link

Ugh, this is killing me in azure government. It isn't supported there and it breaks my deployment. I should have tested the version but when you have a closed network you tend to grab the latest so you don't have to do the move that often.

We definitely don't want default to true.

@frbar
Copy link

frbar commented Aug 6, 2020

It has no effect with 2.21. I can set it to true or false in the Terraform template, and switch the radio button back and forth in the Azure Portal, in all cases Terraform plan detects nothing.

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 13, 2020
@sdebruyn sdebruyn deleted the add-storage-account-allow-blob-public-access branch December 7, 2021 22:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for allow_blob_public_access property in azurerm_storage_account
5 participants