Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_database remove forcenew and add custoDiff on sku_name #7559

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Jul 2, 2020

Fix #7461

@ghost ghost added the size/XS label Jul 2, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @yupwei68

Thanks for this PR.

Taking a look through if we can add a test and update the documentation then this should otherwise be good to merge 👍

Thanks!

@ghost ghost added size/M documentation and removed size/XS labels Jul 6, 2020
@yupwei68
Copy link
Contributor Author

yupwei68 commented Jul 6, 2020

Hi Tom, thanks for your comments. Corresponding changes have been pushed. Please continue reviewing.

=== RUN TestAccAzureRMMsSqlDatabase_updateSku
=== PAUSE TestAccAzureRMMsSqlDatabase_updateSku
=== CONT TestAccAzureRMMsSqlDatabase_updateSku
--- PASS: TestAccAzureRMMsSqlDatabase_updateSku (1198.93s)

@ghost ghost removed the waiting-response label Jul 6, 2020
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yupwei68, thanks for the updates - this LGTM 👍

@manicminer manicminer self-assigned this Jul 6, 2020
@manicminer manicminer added this to the v2.18.0 milestone Jul 6, 2020
@manicminer manicminer merged commit b061bd4 into hashicorp:master Jul 6, 2020
manicminer added a commit that referenced this pull request Jul 6, 2020
tombuildsstuff pushed a commit that referenced this pull request Jul 6, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@yupwei68 yupwei68 deleted the wyp-mssqldb-sku branch July 10, 2020 02:01
@ghost
Copy link

ghost commented Aug 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing azurerm_mssql_database sku_name deletes and recreates database instead of scaling
3 participants