Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_data_share_dataset_data_lake_gen1 #7511

Merged

Conversation

yupwei68
Copy link
Contributor

Partially fix #6480

Sub PR of : #7064

=== RUN TestAccAzureRMDataShareDataSetDataLakeGen1File_basic
=== PAUSE TestAccAzureRMDataShareDataSetDataLakeGen1File_basic
=== CONT TestAccAzureRMDataShareDataSetDataLakeGen1File_basic
--- PASS: TestAccAzureRMDataShareDataSetDataLakeGen1File_basic (395.53s)
=== RUN TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic
=== PAUSE TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic
=== CONT TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic
--- PASS: TestAccAzureRMDataShareDataSetDataLakeGen1Folder_basic (335.91s)
=== RUN TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport
=== PAUSE TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport
=== CONT TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport
--- PASS: TestAccAzureRMDataShareDataSetDataLakeGen1_requiresImport (410.60s)

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68, thanks for opening this PR... it looks more or less really good, however I did leave a few comments on some very minor changes I would like to see done. Thanks again! 🚀

@yupwei68 yupwei68 requested a review from WodansSon July 14, 2020 06:58
@yupwei68
Copy link
Contributor Author

Hi @WodansSon Thanks for your comments. Corresponding changes have been pushed. Please continue reviewing.

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68, awesome! thanks for pushing those changes. This LGTM now! 🚀

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @yupwei68 - aside from my one comment about a schema change this LGTM 👍

@yupwei68
Copy link
Contributor Author

hi @katbyte Thanks for your comments. Corresponding changes have been pushed. Please continue reviewing.

@yupwei68 yupwei68 requested a review from katbyte July 20, 2020 08:09
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68! LGTM 👍

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit 22523f9 into hashicorp:master Jul 22, 2020
WodansSon added a commit that referenced this pull request Jul 22, 2020
@ghost
Copy link

ghost commented Jul 23, 2020

This has been released in version 2.20.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.20.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [Data Share]
4 participants