Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_kusto_database_principal_assignment #7484

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented Jun 25, 2020

fixes #7383

@jrauschenbusch
Copy link
Contributor Author

@katbyte This is currently WIP. I'll need to check whether everything works correctly. After all we need to deprecate the old "azurerm_database_principal" resource and give a hint to the new available resource within the docs.

@jrauschenbusch jrauschenbusch force-pushed the r-kusto-database-principal-assignment branch 2 times, most recently from 6010ea9 to a7c9fa6 Compare June 25, 2020 09:28
@jrauschenbusch jrauschenbusch changed the title Kusto Database Principal Assignment Support New Resource: azurerm_kusto_database_principal_assignment Jun 29, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-database-principal-assignment branch 3 times, most recently from cc27375 to fa0237f Compare July 1, 2020 17:00
@jrauschenbusch
Copy link
Contributor Author

@mbfrahry As it's the same structure as azurerm_kusto_cluster_principal_assignment it could make sense that you also review this one. Notes from the other PR are already applied.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jrauschenbusch
Many thanks for this new resource. It's looking really good, just a few minor changes below to address (some are items I'll be fixing up at a later date in the azurerm_kusto_cluster_principal_assignment resource which I'm guessing you based this on?)

One additional item not in the comments below, could you add a requiresImport acceptance test?

Thanks again!

@ghost ghost added the dependencies label Jul 8, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-database-principal-assignment branch from b287e37 to 02f1723 Compare July 8, 2020 08:42
@ghost ghost added size/XXL and removed size/XL labels Jul 8, 2020
@jrauschenbusch
Copy link
Contributor Author

@jackofallops I've fixed everything and added the requiresImport acc test. And yes, everything was based on the azurerm_kusto_cluster_principal_assignment resource.

Please review again. I had to do a go mod vendor which updated the vendors folder. I don't know if the diffs should really be there. Please consider it within the review.

@jackofallops
Copy link
Member

Tests passing:
image

@jackofallops jackofallops added this to the v2.18.0 milestone Jul 8, 2020
@jackofallops jackofallops self-assigned this Jul 8, 2020
@jackofallops jackofallops force-pushed the r-kusto-database-principal-assignment branch from 0f6c53c to 14bac7a Compare July 9, 2020 07:16
@ghost ghost added size/XL and removed size/XXL labels Jul 9, 2020
@jackofallops jackofallops merged commit 87ff7ff into hashicorp:master Jul 9, 2020
jackofallops added a commit that referenced this pull request Jul 9, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@jrauschenbusch jrauschenbusch deleted the r-kusto-database-principal-assignment branch July 18, 2020 09:46
@ghost
Copy link

ghost commented Aug 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_kusto_database_principal Provider produced inconsistent result after apply when using Azure Function
2 participants