Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster - Support trusted_external_tenants #7374

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented Jun 17, 2020

Enables access to Kusto clusters from external tenants.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for allt he PRs @jrauschenbusch! this looks good but i think we'll need to mark it as computed? (and maybe config mode atter so it can be cleared to nothing)

getting a perma diff running the tests

trusted_external_tenants.#: "1" => "0"
          trusted_external_tenants.0: "*" => ""

@katbyte katbyte added this to the v2.16.0 milestone Jun 23, 2020
@tombuildsstuff tombuildsstuff removed this from the v2.16.0 milestone Jun 25, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-trusted-external-tenants branch from 9118488 to 427f811 Compare June 29, 2020 06:33
@ghost ghost added the documentation label Jun 29, 2020
@jrauschenbusch
Copy link
Contributor Author

@katbyte Fixed your notes. Please review.

@ghost ghost removed the waiting-response label Jun 29, 2020
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-trusted-external-tenants branch from 427f811 to d8c2517 Compare June 30, 2020 04:54
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Support for Kusto Cluster External Trusted Tenants azurerm_kusto_cluster - Support trusted_external_tenants Jul 8, 2020
@mbfrahry mbfrahry merged commit edf4cdc into hashicorp:master Jul 8, 2020
mbfrahry added a commit that referenced this pull request Jul 8, 2020
@jrauschenbusch jrauschenbusch deleted the r-kusto-cluster-trusted-external-tenants branch July 9, 2020 05:14
@mbfrahry mbfrahry added this to the v2.18.0 milestone Jul 9, 2020
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.18.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants