Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster - Support for virtual_network_configuration #7369

Conversation

jrauschenbusch
Copy link
Contributor

@jrauschenbusch jrauschenbusch commented Jun 17, 2020

Solves #6855

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jrauschenbusch, this is nearly there! Just a couple minor checks to make sure we don't panic

@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-virtual-network-configuration branch from 480a924 to 487c312 Compare June 21, 2020 09:51
@jrauschenbusch jrauschenbusch force-pushed the r-kusto-cluster-virtual-network-configuration branch from 487c312 to 210a0b9 Compare June 21, 2020 10:28
@jrauschenbusch
Copy link
Contributor Author

Hey @mbfrahry, all review notes have been fixed.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Support for Kusto Cluster VNET Configuration azurerm_kusto_cluster - Support for virtual_network_configuration Jun 22, 2020
@mbfrahry mbfrahry added this to the v2.16.0 milestone Jun 22, 2020
@mbfrahry mbfrahry merged commit 9741d6f into hashicorp:master Jun 23, 2020
mbfrahry added a commit that referenced this pull request Jun 23, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

jrauschenbusch added a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch added a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
jrauschenbusch pushed a commit to jrauschenbusch/terraform-provider-azurerm that referenced this pull request Jun 29, 2020
@jrauschenbusch jrauschenbusch deleted the r-kusto-cluster-virtual-network-configuration branch July 9, 2020 05:16
@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants