Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended EventGrid event subscription webhook support #7207

Conversation

jrauschenbusch
Copy link
Contributor

Extended webhook configuration options for resource azurerm_eventgrid_event_subscription.

@jrauschenbusch jrauschenbusch changed the title Extended EventGrid webhook support Extended EventGrid event subscription webhook support Jun 4, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jrauschenbusch

Thanks for this PR - taking a look through this LGTM, would you mind rebasing this and then we should be able to kick off the tests/get this merged 👍

Thanks!

@jrauschenbusch jrauschenbusch force-pushed the r-eventgrid-event-subscription-extended-webhook-support branch from 7b79ca8 to cedcffe Compare June 6, 2020 08:37
@jrauschenbusch
Copy link
Contributor Author

@tombuildsstuff I've rebased everything. Ready to get merged.

@ghost ghost removed the waiting-response label Jun 6, 2020
@tombuildsstuff tombuildsstuff added this to the v2.14.0 milestone Jun 8, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jrauschenbusch

Thanks for pushing those changes - taking a look through if we can add documentation for the base_url field then this otherwise LGTM 👍

Thanks!

@jrauschenbusch
Copy link
Contributor Author

@tombuildsstuff I've added the documentation. Please review and ping me back if it LGTY.

@ghost ghost removed the waiting-response label Jun 10, 2020
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2020-06-11 at 11 04 05

@tombuildsstuff tombuildsstuff merged commit ebc53a3 into hashicorp:master Jun 11, 2020
tombuildsstuff added a commit that referenced this pull request Jun 11, 2020
@ghost
Copy link

ghost commented Jun 11, 2020

This has been released in version 2.14.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.14.0"
}
# ... other configuration ...

@jrauschenbusch jrauschenbusch deleted the r-eventgrid-event-subscription-extended-webhook-support branch July 9, 2020 05:15
@ghost
Copy link

ghost commented Jul 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants