Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_server: New attributes, flatten storage_profile block #6833

Merged
merged 6 commits into from
May 14, 2020

Conversation

manicminer
Copy link
Contributor

  • create_mode, creation_source_server_id,
    infrastructure_encryption_enabled,
    ssl_minimal_tls_version_enforced

  • Support replicas and point-in-time restores

  • Use booleans for toggle properties, renaming

    • auto_grow -> auto_grow_enabled
    • geo_redundant_backup -> geo_redundant_backup_enabled
    • ssl_enforcement -> ssl_enforcement_enabled
  • Remove redundant storage_profile block and move all properties
    within to top level

Fixes: #4756
Related: #6459

- `create_mode`, `creation_source_server_id`,
  `infrastructure_encryption_enabled`,
  `ssl_minimal_tls_version_enforced`

- Support replicas and point-in-time restores

- Use booleans for toggle properties, renaming
  * `auto_grow` -> `auto_grow_enabled`
  * `geo_redundant_backup` -> `geo_redundant_backup_enabled`
  * `ssl_enforcement` -> `ssl_enforcement_enabled`

- Remove redundant `storage_profile` block and move all properties
  within to top level

Fixes: #4756
Related: #6459
@manicminer manicminer force-pushed the i/mysql-server/new-properties branch from da1043a to e11c860 Compare May 11, 2020 22:55
@katbyte katbyte added this to the v2.10.0 milestone May 14, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr @manicminer! LGTM 👍

@katbyte katbyte merged commit d207eaa into master May 14, 2020
@katbyte katbyte deleted the i/mysql-server/new-properties branch May 14, 2020 03:46
katbyte added a commit that referenced this pull request May 14, 2020
@yashwanthkalva
Copy link

yashwanthkalva commented May 14, 2020

Hi TF team,

Can you please let us know from which version of terraform azure mysql server provider version will we get support for replicas ?

@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating replicas in Azure Database for MySQL
3 participants