Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_batch_pool - support container_image_names property #6689

Merged

Conversation

ivanguravel
Copy link
Contributor

@ghost ghost added the size/XS label Apr 29, 2020
@katbyte katbyte added this to the v2.12.0 milestone May 24, 2020
@katbyte katbyte changed the title add container image name property azurerm_batch_pool - support container_image_names property May 24, 2020
@ghost ghost added size/XL and removed size/XS labels May 24, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ivanguravel,

I hope you don't mind but the update wasn't setting this property & the docs needed updating. I hope you don't mind but i've pushed the required changes to get this merged 🙂

@ghost ghost added the documentation label May 25, 2020
@katbyte katbyte merged commit 91d5287 into hashicorp:master May 25, 2020
katbyte added a commit that referenced this pull request May 25, 2020
@ivanguravel
Copy link
Contributor Author

Thanks for the PR @ivanguravel,

I hope you don't mind but the update wasn't setting this property & the docs needed updating. I hope you don't mind but i've pushed the required changes to get this merged 🙂

Thanks 4 your help! I had a lot of work and totally skip those fixes. :(

@ghost
Copy link

ghost commented May 28, 2020

This has been released in version 2.12.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.12.0"
}
# ... other configuration ...

pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
…orp#6689)

this is a pr which helps to configure docs.microsoft.com/en-us/dotnet/api/microsoft.azure.batch.containerconfiguration.containerimagenames?view=azure-dotnet
pbrit pushed a commit to pbrit/terraform-provider-azurerm that referenced this pull request May 31, 2020
@ghost
Copy link

ghost commented Jun 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants