azurerm_public_ip_prefix: Update prefix_length validation to accept all valid IPv4 address ranges
#6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New test failed as expected due to subscription public ip limits |
|
This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.7.0"
}
# ... other configuration ... |
neil-yechenwei
pushed a commit
to neil-yechenwei/terraform-provider-azurerm
that referenced
this pull request
Apr 26, 2020
…pt all valid IPv4 address ranges (hashicorp#6589) * Update prefix length validation * Updated documentation for new ranges * Add test and change upper limit to 31 * Update error msgs to be go compliant * Add note to test case about subscription config
neil-yechenwei
pushed a commit
to neil-yechenwei/terraform-provider-azurerm
that referenced
this pull request
Apr 26, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feb 11, 2020 there was a change to the resource to restrict the range to be between 28 and 31 due to the product documentation which states that by default /28 is the maximum limit, however also in the documentation it states that you should contact customer support to change the default limit of /28.
Since there is no way for terraform to know the approved range for a given subscription I have opened up the validation to check that the passed value is between
0and31, which should cover all possible IPv4 scenarios.