Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID not set when retrieving data factory fix #4827 #6492

Conversation

pearcec
Copy link
Contributor

@pearcec pearcec commented Apr 15, 2020

The data source for data factory id was not set during Read. Set the ID
added a better acctest to validate.

Fixes #4827

The data source for data factory id was not set during Read.  Set the ID
added a better acctest to validate.
@ghost ghost added the size/S label Apr 15, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @pearcec

@tombuildsstuff tombuildsstuff added this to the v2.6.0 milestone Apr 16, 2020
@tombuildsstuff tombuildsstuff merged commit be1294f into hashicorp:master Apr 16, 2020
tombuildsstuff added a commit that referenced this pull request Apr 16, 2020
@pearcec pearcec deleted the azurerm_data_factory_data_source_missing_values_#4827 branch April 16, 2020 11:19
@ghost
Copy link

ghost commented Apr 16, 2020

This has been released in version 2.6.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.6.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_data_factory data source missing values
2 participants