Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_postgres_server - fix #2819, #5121, #5865, #6180, #6216 #6459

Merged
merged 14 commits into from
Apr 21, 2020

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Apr 14, 2020

refactor code and tests to

  • support for create_mode, creation_source_server_id, infrastructure_encryption_enabled,public_network_access_enabled, ssl_minimal_tls_version_enforced properties
  • support replicas
  • computed storage_mb when auto_grow_enabled is true
  • use booleans for toggle properties by renaming:
    -- ssl_enforcement -> ssl_enforcement_enabled
    -- geo_redundant_backup -> backup_geo_redundant_enabled
    -- auto_grow -> auto_grow_enabled
  • move all properties within the storage_profile block to the top level

superseeds #6241
fixes #6216
fixes #6180
fixes #5865
fixes #5121
fixed #2819

@ghost ghost added the size/XL label Apr 14, 2020
@katbyte katbyte requested a review from a team April 14, 2020 03:53
@katbyte katbyte added this to the v2.6.0 milestone Apr 14, 2020
@ghost ghost added the documentation label Apr 15, 2020
@katbyte katbyte changed the title azurerm_postgres_server - refactor and support more azurerm_postgres_server - fix #2819, #5121, #5865, #6180, #6216 Apr 15, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.6.0, v2.7.0 Apr 16, 2020
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments inline but this otherwise LGTM 👍

@katbyte katbyte force-pushed the kt/not-yesterdays-postgres-server branch from a691fd3 to 2911d2f Compare April 21, 2020 19:23
@katbyte katbyte merged commit e969b88 into master Apr 21, 2020
@katbyte katbyte deleted the kt/not-yesterdays-postgres-server branch April 21, 2020 20:01
katbyte added a commit that referenced this pull request Apr 21, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@larryclaman
Copy link

@katbyte, you wrote that the following property was renamed: geo_redundant_backup -> backup_geo_redundant_enabled

There's a typo in your notes; from looking at the code, the new parameter is actually geo_redundant_backup_enabled

Can you edit your initial comment to reflect the correction?

manicminer added a commit that referenced this pull request May 8, 2020
- `create_mode`, `creation_source_server_id`,
  `infrastructure_encryption_enabled`,
  `ssl_minimal_tls_version_enforced`

- Support replicas and point-in-time restores

- Use booleans for toggle properties, renaming
  * `auto_grow` -> `auto_grow_enabled`
  * `geo_redundant_backup` -> `geo_redundant_backup_enabled`
  * `ssl_enforcement` -> `ssl_enforcement_enabled`

- Remove redundant `storage_profile` block and move all properties
  within to top level

Fixes: #4756
Related: #6459
manicminer added a commit that referenced this pull request May 11, 2020
- `create_mode`, `creation_source_server_id`,
  `infrastructure_encryption_enabled`,
  `ssl_minimal_tls_version_enforced`

- Support replicas and point-in-time restores

- Use booleans for toggle properties, renaming
  * `auto_grow` -> `auto_grow_enabled`
  * `geo_redundant_backup` -> `geo_redundant_backup_enabled`
  * `ssl_enforcement` -> `ssl_enforcement_enabled`

- Remove redundant `storage_profile` block and move all properties
  within to top level

Fixes: #4756
Related: #6459
manicminer added a commit that referenced this pull request May 11, 2020
- `create_mode`, `creation_source_server_id`

- Support replicas and point-in-time restores

- Use booleans for toggle properties, renaming
  * `auto_grow` -> `auto_grow_enabled`
  * `geo_redundant_backup` -> `geo_redundant_backup_enabled`
  * `ssl_enforcement` -> `ssl_enforcement_enabled`

- Remove redundant `storage_profile` block and move all properties
  within to top level

- Remove unpopulated attribute `administrator_login_password` from
  `mariadb_server` data source

Fixes: #4296, #6521
Related: #6459
manicminer added a commit that referenced this pull request May 12, 2020
- `create_mode`, `creation_source_server_id`

- Support replicas and point-in-time restores

- Use booleans for toggle properties, renaming
  * `auto_grow` -> `auto_grow_enabled`
  * `geo_redundant_backup` -> `geo_redundant_backup_enabled`
  * `ssl_enforcement` -> `ssl_enforcement_enabled`

- Remove redundant `storage_profile` block and move all properties
  within to top level

- Remove unpopulated attribute `administrator_login_password` from
  `mariadb_server` data source

Fixes: #4296, #6521
Related: #6459
manicminer added a commit that referenced this pull request May 12, 2020
- `create_mode`, `creation_source_server_id`,
  `public_network_access_enabled`

- Support replicas and point-in-time restores

- Use booleans for toggle properties, renaming
  * `auto_grow` -> `auto_grow_enabled`
  * `geo_redundant_backup` -> `geo_redundant_backup_enabled`
  * `ssl_enforcement` -> `ssl_enforcement_enabled`

- Remove redundant `storage_profile` block and move all properties
  within to top level

- Remove unpopulated attribute `administrator_login_password` from
  `mariadb_server` data source

Fixes: #4296, #6521
Related: #6459
@katbyte
Copy link
Collaborator Author

katbyte commented May 14, 2020

@larryclaman thanks for pointing that out! i've updated the pr description with the correct name

katbyte pushed a commit that referenced this pull request May 14, 2020
create_mode, creation_source_server_id,
infrastructure_encryption_enabled,
ssl_minimal_tls_version_enforced

Support replicas and point-in-time restores

Use booleans for toggle properties, renaming

auto_grow -> auto_grow_enabled
geo_redundant_backup -> geo_redundant_backup_enabled
ssl_enforcement -> ssl_enforcement_enabled
Remove redundant storage_profile block and move all properties
within to top level

Fixes: #4756
Related: #6459
@ghost
Copy link

ghost commented May 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.