azurerm_[linux|windows]_virtual_machine - if the priority property on read is empty assume it to be Regular

[kazimierzbudzyk]

Fixes: #6300

[ArcturusZhang]

Hi @kazimierzbudzyk thanks for the PR! A very minor comment which is made to align with the style.
And plus would please also update azurerm_windows_virtual_machine to make sure the two virtual machines align with each other?

[ArcturusZhang]

Could we please do this by assigning the default value first, and then check if response is empty and then assign the real value if it is empty.

Suggested change

	priority := props.Priority
	if priority == "" {
	priority = compute.Regular
	}
	d.Set("priority", string(priority))
	priority := string(compute.Regular)
	if props.Priority != "" {
	priority = string(props.Priority)
	}
	d.Set("priority", priority)

[kazimierzbudzyk]

Thank you for the review @ArcturusZhang! Made changes according to your comments.

[ArcturusZhang]

LGTM now 👍
Some tests on this resource is failing but those look not likely to relate with this change.

[kazimierzbudzyk]

Thanks! @ArcturusZhang what is the process for getting this added to a release?

[ghost]

This has been released in version 2.5.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.5.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!