New Resource - azurerm_custom_resource_provider
#6234
Conversation
mbfrahry
commented
Mar 24, 2020
mbfrahry
commented
| Validations: expandCustomResourceProviderValidation(d.Get("validation").([]interface{})), | ||
| }, | ||
| Location: &location, | ||
| Tags: tags.Expand(t), |
There was a problem hiding this comment.
should we do
| Tags: tags.Expand(t), | |
| Tags: tags.Expand(d.Get("tags").(map[string]interface{})), |
| return fmt.Errorf("retrieving Custom Resource Provider %q (Resource Group %q): %+v", name, resourceGroup, err) | ||
| } | ||
|
|
||
| if resp.ID == nil { |
There was a problem hiding this comment.
Should we check if id is "" empty here too?
| return validations | ||
| } | ||
|
|
||
| func validateCustomResourceProviderName(v interface{}, k string) (warnings []string, errors []error) { |
There was a problem hiding this comment.
Could we put this into a /customproviders/validate package?
| features {} | ||
| } | ||
| resource "azurerm_resource_group" "test" { | ||
| name = "acctestRG-cr-%d" |
There was a problem hiding this comment.
should this be
| name = "acctestRG-cr-%d" | |
| name = "acctestRG-cp-%d" |
for custom providers?
|
|
||
| * `name` - (Required) Specifies the name of the route definition. | ||
|
|
||
| * `endpoint` - (Required) Specifies the endpoint of the route definition. |
There was a problem hiding this comment.
are endpoints always urls? should we validate its a url?
| "resource_group_name": azure.SchemaResourceGroupName(), | ||
|
|
||
| "resource_type": { | ||
| Type: schema.TypeList, |
There was a problem hiding this comment.
Should these properties all be sets or does order matter/duplicates allowed?
|
|
||
| A `validation` block supports the following: | ||
|
|
||
| * `specification` - (Required) The endpoint where the validation specification is located. |
There was a problem hiding this comment.
the type property is missing from here?
|
|
||
| * `name` - (Required) Specifies the name of the action. | ||
|
|
||
| * `endpoint` - (Required) Specifies the endpoint of the action. |
There was a problem hiding this comment.
the type property is missing from here?
| * `name` - (Required) Specifies the name of the route definition. | ||
|
|
||
| * `endpoint` - (Required) Specifies the endpoint of the route definition. | ||
|
|
There was a problem hiding this comment.
the type property is missing from here?
| "specification": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.NoZeroValues, |
|
This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.3.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
