Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: azurerm_network_service_tags #6229

Merged
merged 13 commits into from
Mar 26, 2020

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Mar 23, 2020

Service Tags / address prefixes are useful when using firewall rules or UDRs in some scenarios.

Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

@r0bnet
Copy link
Contributor Author

r0bnet commented Mar 24, 2020

@magodo i changed everything accordingly. Any problems left?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @r0bnet, I have some questions about the filter attribute and regional/global tags that can be found in the comments i've left inline. Additionaly there is some minor code changes i'd like to see. Thanks!

# Conflicts:
#	azurerm/internal/services/compute/tests/resource_arm_managed_disk_test.go
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @r0bnet, looks good now aside from we still need to nil check region before dereferencing. Hope you don't mind but i'm going to push that change myself to get this merged!

@r0bnet
Copy link
Contributor Author

r0bnet commented Mar 26, 2020

@katbyte all good, i'm fine with you pushing changes. But don't know why the tests are failing. I ran them locally with no error. I just merged master so see if those were temp issues.

@ghost ghost removed the waiting-response label Mar 26, 2020
@katbyte katbyte added this to the v2.3.0 milestone Mar 26, 2020
@katbyte katbyte changed the title New data source: Service Tags New data source: azurerm_network_service_tags Mar 26, 2020
@katbyte katbyte merged commit 5543fec into hashicorp:master Mar 26, 2020
katbyte added a commit that referenced this pull request Mar 26, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants