Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Azure SDK to v40.3.0 / AzureAD to v0.8.0 #6134

Merged
merged 7 commits into from
Mar 19, 2020

Conversation

tombuildsstuff
Copy link
Contributor

This PR supersedes #6049 as nested go modules and merge conflicts do not spark joy - but fundamentally this:

Enables #5769
Enables #5696

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sebader
Copy link
Contributor

sebader commented Mar 18, 2020

btw, the title of this PR is a bit misleading as it states Azure SDK v43.0 instead of v40.3.0 :) Or did I misunderstood something in the versioning for the go sdk?

@tombuildsstuff tombuildsstuff changed the title Updating the Azure SDK to v43.0 / AzureAD to v0.8.0 Updating the Azure SDK to v40.3.0 / AzureAD to v0.8.0 Mar 18, 2020
@tombuildsstuff
Copy link
Contributor Author

@sebader good spot 😅

@katbyte katbyte modified the milestones: v2.2.0, v2.3.0 Mar 18, 2020
@katbyte katbyte merged commit 753fe90 into master Mar 19, 2020
@katbyte katbyte deleted the deps/azure-sdk-40.3 branch March 19, 2020 03:25
katbyte added a commit that referenced this pull request Mar 19, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants